search

dvlden / ultrawideo-v2

Upscale or stretch any video on the web, to make it look great on UltraWide screens.
MIT License
135 stars 19 forks source link

Android Smartphone Video Streching works partially #81

Closed downtoground closed 1 year ago

downtoground commented 2 years ago

Im running this extension on my Android LOS19. The Kiwi Browser is able to run Extensions.

The Extension works out of the box, but the mode "Streching" wont use the whole screen over the camera.

This Extension works better: https://chrome.google.com/webstore/detail/zoom-to-fill-ultrawide-vi/adpjimagbfpknkodpofjphpbdlfkeiho but has no gestures!

Hope for a Fix! Thanks a lot

downtoground commented 2 years ago

Push ;-)

dvlden commented 1 year ago

Screenshots and video recordings are appreciated. I do not have an Android and the extension is made primarily for desktop use, but I can try to debug through an emulator.

R0M4N0F5K7 commented 1 year ago

I noticed the same thing when I installed this addon on mobile ages ago, but assumed it can't be fixed, as the browser/app doesn't reach past the "layout bounds" that is defined by the set "display cutout (nodge/hole punch area) by the system (you can visualize and change them in the developer options). You can see that even without this addon full screen videos are only centered within the layout bounds marked as below the display cutout.

But if someone says it works with the addon above... Would be really cool to have a toggle like "expand fullscreen past punchholes" that overwrites/ignores those layout bounds set by the display cutout.

That's what it looks like:

Here you can see the out of bounds area, basically it stops app canvases under punch holes so that the punchhole doesn't hide content). Marked where the punchhole would be on my screen blue. Screenshot_20230309-175347~3

This is what normal fullscreen looks like. As you can see even fullscreen doesn't consider space past the off-limit area under the punch hole: Screenshot_20230309-175328~2

This makes zooming the video weird and is what people are talking about: Screenshot_20230309-175314~2

dvlden commented 1 year ago

Oh very interesting. Thanks for this information @R0M4N0F5K7 . I can see your point. Would be nice if you can find an video for your mobile's Aspect Ratio, and see if that one fits all the way through without the extension.

If it does, it means it's possible.

R0M4N0F5K7 commented 1 year ago

Nah the full screen mode of the mobile browser seems to be confined to the area under the display cutout just as in any other view of the browser. I think the app makers have to support this (i.e. the browsers in our case would have to overwrite the display cutout areas when going fullscreen). It seems to me that the reason why this obvious thing doesn't seem to be implemented in all mobile browsers is that some versions of andoid (Huawei, maybe Samsung?) have implemented workounds on their OS level that detect fullscreen attempts or even let users hide the display cutout manually via gestures. With that some browser developers don't see the need to act themselves as it does work for some users.

There might be a hacky way to work around that, but I get the notion that it might not be worth the effort for this addon all things considered.

dvlden commented 1 year ago

Okay, that's about right then. I was thinking if fullscreen video in the browser actually takes all that space, then it would be a bug with the extension.

Thanks for your research and time!