search

dvlden / ultrawideo-v2

Upscale or stretch any video on the web, to make it look great on UltraWide screens.
MIT License
135 stars 19 forks source link

Vertical videos don't behave well #85

Closed francislavoie closed 2 years ago

francislavoie commented 2 years ago

Describe the bug

This is on the Upscale mode.

For example https://www.reddit.com/r/interestingasfuck/comments/x7nftw/unusual_cube_shaped_cloud_seen_in_the_uk/ it ends up stretching the vertical video to the full width of the display, which means I only see like the top 1/3 of the video. Kinda sucks.

Also tangentially, I have two monitors, a 21:9 and a 16:9. If I fullscreen a video on my 16:9 that is wider than that, e.g. an 18:9 youtube video for example https://www.youtube.com/watch?v=m53_jtJR-Ig, it ends up cutting off some of the sides.

Reproduction steps

(see above)

Expected behavior

Videos shouldn't stretch past the edges of the screen.

Environment

dvlden commented 2 years ago

Everything you have just described sounds like the extension is working as expected. Yes, vertical videos will be stretched or upscaled if you select these modes, select Normal mode if you don't want them affected.

And yes, some sides will be cut off on upscale for various resolutions when the video aspect ratio doesn't match the screen.

francislavoie commented 2 years ago

Is there not a way to detect the actual height of the video, and cap the scaling to its height? Doesn't feel like upscaling to shift most of the video off the screen makes much sense. Especially on websites (like Reddit) where you don't really know from one video to the next whether it'll be vertical or horizontal.