Closed XVincentX closed 8 years ago
Couple of changes:
.editorconfig
. We already have eslint
to handle our stylings, which is considerably more robust for javascript specific styling. If you want to continue to use it locally, feel free to add it to the .gitignore
, but I'd like to treat eslint
as the source of truth for styling.dist
out of the .gitignore
(as in, actually commit it to the repository). I'd actually like to keep those files in the repository (at least for now). I may change that in the future, but since they're currently available in the repo, lets keep them there for now.Other than that, looks good! I'll merge it in afterwards. Thanks for your work!
.editorconfig
file was to avoid most of common eslint
warnings solved automagically at save time. But I can live without that file.Anyway, comments should be addessed in https://github.com/dvlsg/async-csp/pull/14/commits/e8b0f938066718d99f7fc1c5ffa1623ee3b65174#diff-1e70daafb475c0ce3fef7d2728279182
Awesome, thanks! I'll merge it in, and work on publishing something out which will give you access to that umd file through npmcdn. Hopefully this weekend at some point (I have a few other things I want in the next release that aren't quite done yet).
This would solve #13