dvmarinoff / Flux

Indoor Cycling App for Structured Training
https://flux-web.vercel.app
GNU Affero General Public License v3.0
505 stars 86 forks source link

Showing workout progress within intervals #184

Closed daniellytle closed 5 months ago

daniellytle commented 5 months ago

Description

Screenshots

image

https://github.com/dvmarinoff/Flux/assets/8124178/29637bfb-ddee-44b5-b19f-68d083d57bc0

vercel[bot] commented 5 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @dvmarinoff on Vercel.

@dvmarinoff first needs to authorize it.

dvmarinoff commented 5 months ago

Thanks for the PR, will take a look tomorrow’s morning.

dvmarinoff commented 5 months ago

Great job!

Only a few points:

  1. now I am thinking that the current interval indicator #progress-active is redundant and it can go. Maybe making it background-color: transparent; would do for now.

  2. On mobile devices the border-right: 2px solid var(--zone-orange); on #progress is looking too thick, maybe 1px would do better.

Screenshot 2024-03-19 at 10 41 19 Screenshot 2024-03-19 at 10 41 27
  1. and also I am split about the --progress-orange: #ffa60055; color. Maybe white with some opacity also works #fff4. What do you think? Orange or white?
Screenshot 2024-03-19 at 10 28 44
daniellytle commented 5 months ago

I like those changes, I'll put up another commit with them up today.