If the error handler function is not passed to 'request' then it can throw an uncatchable exception.

dvonlehman / express-request-proxy

Advanced streaming http request proxy middleware for Express with support for custom routes, caching, and response transforms.

95 stars 38 forks source link

If the error handler function is not passed to 'request' then it can throw an uncatchable exception. #42

Open gautam1168 opened 5 years ago

gautam1168 commented 5 years ago

Since the library is not allowing us to pass an error handler we are unable to catch the ECONNREFUSED error. This error cannot be caught using a try catch block and makes our server crash. Please consider merging this PR.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 91

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.339%

Totals
Change from base Build 85:	0.0%
Covered Lines:	167
Relevant Lines:	180

dvonlehman / express-request-proxy

If the error handler function is not passed to 'request' then it can throw an uncatchable exception. #42

Pull Request Test Coverage Report for Build 91

💛 - Coveralls