search

dvorak321 / gbfr-parser

6 stars 3 forks source link

feat: add targets charts breakdown #7

Closed T-kON99 closed 8 months ago

T-kON99 commented 8 months ago

feat: this is a feature that adds targets breakdown for each actor/action/charts. I hope it's useful

T-kON99 commented 8 months ago

Example preview:

image image

dvorak321 commented 8 months ago

added in commit a49fc03

T-kON99 commented 8 months ago

Correct me if I'm wrong (I have not tried it out, still at work, just skimmed through the commits) but https://github.com/dvorak321/gbfr-parser/commit/a49fc03cd49e1ba3f967a9a42ff306178a705509 does not include each target action breakdowns isn't it? also the DPS chart for each target is not updated

T-kON99 commented 8 months ago

@dvorak321 I just tried https://github.com/dvorak321/gbfr-parser/commit/a49fc03cd49e1ba3f967a9a42ff306178a705509, and I still think this PR is a worthy addition:

  1. It supports per target DPS/Chart
  2. It supports action break down per target

image No specific target selected, means overall damage / dps / chart

image EarthWyrm as the target

image FireWyrm as the target

what do you think? I do think the target selection can be improved.