dvorka / mindforger

Thinking notebook and Markdown editor.
https://www.mindforger.com
GNU General Public License v2.0
2.24k stars 137 forks source link

Metadata is not persistent #1074

Open Asutu opened 4 years ago

Asutu commented 4 years ago

Hi, I just downloaded mindforger and created a new "MindForger Repository" nested within a ~/Documents/.../MF-notes/ folder (this is outside the default one at ~/mindforger-repository/). Everything seems to be working fine when I create notebooks and notes in the top-level of this directory (e.g. ~/Documents/.../Foo/memory/bar1.md). I'd also like to have notebooks structured by some common denominator and thought this could be achieved by "Learning" a new directory with markdown files within the repository; something like the mindforger directory with the documentation that gets copied when creating a new repository. So I asked MF to "Learn" about this new directory (~/Documents/.../Foo/memory/folder1/) and started a new notebook in there (say ~/Documents/.../Foo/memory/folder1/bar2.md). However, it looks that any metadata that I add to the notebooks in this directory (in this case bar2.md) are not persistent and everytime I close and open MF, the metadata is lost. This only happens in the new learned directory; all metadata in the top-level notebooks (e.g. bar1.md) are working OK.

Not sure if this is a bug or feature of MF but thought it would be worth reporting here.

I'm running MF on a MacBook Pro running macOS 10.14.6 Mojave.

Cheers.

P.S. by the way, I think MF is amazing! It does have a bit of a learning curve but its way to organize and structure notebooks is unparalleled and quite promising.

Asutu commented 4 years ago

Update1: only the "Importance" and "Urgency" metadata is not being kept between MF restarts. The preamble seems to be working fine.

Update2: after adding a TOC to the notebook, all metadata is now working fine and persists between MF restarts. Maybe the notebook needs some text to trigger saving of metadata?

dvorka commented 4 years ago

bug

Let me try to reproduce the problem. Let me clarify that there is important metadata limitation:

The reason is that that metadata are stored to Markdown files (as HTML comments) which might undesired when MF is used as Markdown editor.

Perhaps I could make it setting - enable/disable storing of metadata to non-MF repository Markdowns. WDYT @Asutu?

FlorianHeigl commented 3 years ago

@dvorka IMO if it allows to add metadata, then it has to be persistent. So either, if one is in the wrong directory, disable adding tags or, if enabled, save the html. if the user presses "save" they probably expect it to save. I also want to externally edit/create the markdown, but the inline html should not hurt?