search

dvreeze / tqa

XBRL Taxonomy Query API
Apache License 2.0
6 stars 3 forks source link

Catalog file location not conform XBRL spec #4

Open fourth44 opened 2 years ago

fourth44 commented 2 years ago

Hi Chris! Hope you are doing well!

According to https://www.xbrl.org/Specification/taxonomy-package/REC-2016-04-19/taxonomy-package-REC-2016-04-19.html, a taxonomy package zip should contain only a single root entry, which is a folder with the same name as the zip file itself:

A Taxonomy Package MUST contain a single top-level directory, with all other files being contained within that directory or descendant subdirectories (tpe:invalidDirectoryStructure). It is recommended, but not required, that the name of the top-level directory be the same as the name of the Taxonomy Package with the .zip file extension removed.

In any case it's easy to assume they mean the implicit root of every zip file, but in fact they truly mean that an explicit single folder should be inside the zip.

Currently TQA assumes a top level folder "META-INF/catalog.xml", but that should rather be "???/META-INF/catalog.xml" (see TaxonomyBaseFactoryFromRemoteZip.scala and TaxonomyPackagePartialUriResolver.scala).

dvreeze commented 2 years ago

Hi Johan! Sorry for my late reply. I agree with the issue and your fix. Just an idea: does it make sense for you to fork TQA (and if needed yaidom) to make that the leading fork in practice, until you can entirely replace it with something better, less XML-centric and more modern?