search

dvsekhvalnov / jose-jwt

Ultimate Javascript Object Signing and Encryption (JOSE), JSON Web Token (JWT) and Json Web Keys (JWK) Implementation for .NET and .NET Core
MIT License
936 stars 184 forks source link

Typo in Jwk.NameToCurve #188

Closed zzyzy closed 2 years ago

zzyzy commented 2 years ago

Hello,

It appears there's a typo for the method Jwk.NameToCurve when converting from "P-384" string to ECCurve.

https://github.com/dvsekhvalnov/jose-jwt/blob/4391fa0069abac4d5e7e035845be38914206eb10/jose-jwt/jwk/Jwk.cs#L538

dvsekhvalnov commented 2 years ago

Thanks @zzyzy !

Fix obviously looks good to me :) Can we add unit tests? i've posted comments in PR.

dvsekhvalnov commented 2 years ago

released to nuget.org