Support for ECDH-ES-* on Linux is possible

dvsekhvalnov / jose-jwt

Ultimate Javascript Object Signing and Encryption (JOSE), JSON Web Token (JWT) and Json Web Keys (JWK) Implementation for .NET and .NET Core

MIT License

921 stars 183 forks source link

Support for ECDH-ES-* on Linux is possible #219

Closed polewskm closed 3 months ago

polewskm commented 1 year ago

See the following: https://github.com/polewskm/jose-jwt-ecdh

dvsekhvalnov commented 1 year ago

Hi @polewskm , thanks for snippet. Is it actually working under linux? I don't see calls to Encode`Decode` ?

Assuming the code is for derivation part here: https://github.com/dvsekhvalnov/jose-jwt/blob/master/jose-jwt/jwa/EcdhKeyManagement.cs#L92 ?

polewskm commented 1 year ago

Yes, my implementation is working on Linux. To be clear, you would have to:

Refactor your ConcatKDF.DeriveKey to NOT use ECDiffieHellmanCng (notice the ...Cng suffix here)
There is no equivalent implementation of SP800_56A_CONCAT in Linux
You have to implement the functionality of SP800_56A_CONCAT yourself
That is what my snippet is showing, how to manually implement SP800_56A_CONCAT on Linux using ECDiffieHellman (notice that lack of ...Cng in the suffix here)
...Cng classes cannot be used on Linux as they are Windows only

dvsekhvalnov commented 1 year ago

Sp800_56a is easy to bring, have it somewhere in Go version of lib.

So if you have working version, mind PR then? :)

polewskm commented 1 year ago

Sure can do. It might be a week or two before I submit a PR though.

dvsekhvalnov commented 1 year ago

Will greatly appreciate, thank you.

deepak-sidhyati commented 11 months ago

@dvsekhvalnov @polewskm is there a PR for this?

dvsekhvalnov commented 11 months ago

@deepak-sidhyati , haven't seen PR so far.

Can may be find some time to port it over myself, but can't commit on timeline.

polewskm commented 11 months ago

Sorry, I have been terrible busy with other projects and haven't found the time to work on this yet.

digaomatias commented 10 months ago

Looking forward to this one getting ready to be used as well.

digaomatias commented 10 months ago

Looking forward to this one getting ready to be used as well.

Just want to let you know. I got the code snippet posted by @polewskm and followed his instructions on what should be done. I was able to run the existing unit test for the ConcatKDF class but invoking my method (@polewskm's code) and it passed! Which is great. I'll change the code that uses the ConcatKDF to invoke this new method and see if the unit tests pass overall. I'll come up with a PR in the next few days and you guys can review if it makes sense or not.

dvsekhvalnov commented 10 months ago

Hi @digaomatias , great news, PRs always welcome :)

dvsekhvalnov commented 3 months ago

v5.0.0 released to nuget.org

https://github.com/dvsekhvalnov/jose-jwt/releases/tag/v5.0.0