search

dvsekhvalnov / jose-jwt

Ultimate Javascript Object Signing and Encryption (JOSE), JSON Web Token (JWT) and Json Web Keys (JWK) Implementation for .NET and .NET Core
MIT License
936 stars 184 forks source link

use correct framework #246

Closed kasperk81 closed 4 months ago

kasperk81 commented 4 months ago

the undocumented names (without period in dotnet 5+) can drop their support when move to double-digit (to avoid potential conflicts) https://learn.microsoft.com/en-us/dotnet/standard/frameworks#supported-target-frameworks

dvsekhvalnov commented 4 months ago

Hi @kasperk81 , thanks for PR.

Yeah, sounds like good idea. But it seems pipeline checks are broken, may be need to exclude install dotnet 2.1/3.1 on macos-latest. Seems no more .net 2 archive for OSX.

kasperk81 commented 4 months ago

it seem to have worked with @v4 and by dropping netcoreapp2.1 from the matrix. https://github.com/kasperk81/jose-jwt/actions/runs/9116199490

dvsekhvalnov commented 4 months ago

Looks good to me, thanks !