search

dvsekhvalnov / jose-jwt

Ultimate Javascript Object Signing and Encryption (JOSE), JSON Web Token (JWT) and Json Web Keys (JWK) Implementation for .NET and .NET Core
MIT License
946 stars 184 forks source link

Any plan to move the solution to the new VS 2017 format #71

Open StefH opened 7 years ago

StefH commented 7 years ago

Do you have any plans to migrate the solution to the new VS 2017 csproj format ?

And additional question : why do you require netstandard 1.4 instead of netstandard 1.3 ?

dvsekhvalnov commented 7 years ago

Hi @StefH ,

  1. instead of project.json? will it solve any issues?

  2. was missing some package in netstandard 1.3, can't recall which one exactly to be honest.

StefH commented 7 years ago
  1. It's better to move on to the new format, better support for .net core / .netstandard in vs 2017
  2. It's always better to keep the dependencies as low as possible.

I can help you on both points, do you want help?

dvsekhvalnov commented 7 years ago

Hi @StefH ,

sure i'm always open to merge requests.

If you gonna migrate off from project.json, please submit to separate branch (not master), i probably will need to upgrade my dev env first.

aidapsibr commented 7 years ago

Heads-up that VS 2017 does not support (visually) multi-targeting with csproj as well as it did on project.json. I just did multi targeting last night and it was all csproj work.

StefH commented 7 years ago

Indeed correct. I do also have moved a lot of projects to the new csproj format, and all is some manual work. But creating NuGets is very easy.