search

dvtng / react-loading-skeleton

Create skeleton screens that automatically adapt to your app!
MIT License
3.87k stars 155 forks source link

Fix typescript module nodenext compatibility #182

Closed rubencosta closed 1 year ago

rubencosta commented 1 year ago

This PR fixes #181

Warning: I changed the exports from default export to named export which is a breaking change. An alternative to a breaking change would be to keep both named and default exports but may be confusing for the package user to figure out which export to use.

msobiecki commented 1 year ago

You should additionally update the readme. ;)

I reworked stackblitz (https://github.com/dvtng/react-loading-skeleton/issues/142#issuecomment-1166791234) to test this solution: https://stackblitz.com/edit/github-qvxva3?file=pages%2Findex.js

rubencosta commented 1 year ago

Thanks @msobiecki, I have updated the readme.

srmagura commented 1 year ago

Fixed this in #187. Thanks for adding the exports to package.json — I used that in my PR.