search

dvtng / react-loading-skeleton

Create skeleton screens that automatically adapt to your app!
MIT License
3.87k stars 155 forks source link

Update skeleton.css - using new animation color defaults #204

Closed mrisher closed 1 year ago

mrisher commented 1 year ago

Using more contrasty defaults, per your README example settings for the SkeletonTheme. The former defaults make the animation effect too subtle on my monitor

srmagura commented 1 year ago

Does this change the skeleton to a dark theme? That seems like a really big change.

There also appears to be a syntax error (double #) in your code.

mrisher commented 1 year ago

No I don't think so. This changes the foreground color from white and almost-white to white and dark grey. It shouldn't change the overall to dark mode, but maybe if you're in light mode you'd want different colors?

On Thu, Jul 20, 2023, 7:13 PM Sam Magura @.***> wrote:

Does this change the skeleton to a dark theme? That seems like a really big change.

There also appears to be a syntax error (double #) in your code.

— Reply to this email directly, view it on GitHub https://github.com/dvtng/react-loading-skeleton/pull/204#issuecomment-1644292010, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABVHNWQKFNDOFJ6NZ3JEV3XRFRJZANCNFSM6AAAAAA2RRQXCY . You are receiving this because you authored the thread.Message ID: @.***>

srmagura commented 1 year ago

Unless I am missing something, neither of the colors you added are white (or near-white).

I'm going to close this because I think it is too big of a change to the library. Most users have been happy with the default colors. Feel free to use SkeletonTheme if you'd like to customize the colors in your app. Thanks.