Closed Yayroos closed 9 months ago
Many thanks for your contribution! π
However, please do not include styling change in an MR, follow the current ones (e.g. use single quotes and not double quotes).
Styling change could be done in a separate MR through an automatic process (much easier to review). I should set these for the whole project so that there's not ambiguity...
Will do - friend was helping me sort out the git stuff and applied the prettier formatting defaults so everything got rearranged.
Will do - friend was helping me sort out the git stuff and applied the prettier formatting defaults so everything got rearranged.
No worries, I need a more exhaustive eslint config file (including prettier styling)
Have reverted all those other files - this should just be the files i touched to actually add the feature
Good stuff, I'll let you merge it @Yayroos π
Forgot to add something but I'm sure it's fine...
When you modify the UI in any way, please post a screenshot of your modification (the extra setting in this case). You can still go ahead and merge this PR though.
i'll grab a screenshot today!
thanks for your quick responses and patience.
i'll grab a screenshot today!
thanks for your quick responses and patience.
No worries, it's fun to see contributions to Lofi :) Also, thanks for being understanding. I hope you learned a bit during this review.
i will get to this - i got covid and sitting up for more than 5 minutes hurts
i will get to this - i got covid and sitting up for more than 5 minutes hurts
No worries, I can squash and merge for you, but I want you to press that button. I don't know why but it's a good feeling to press that Squash and merge
button :)
This code isn't going anywhere.
i'll do it, maybe this afternoon if i can actually use my proper laptop. I'm keen to do it, i just can't think straight or sit up properly at the moment, so it'll have to wait until i shake the damn virus
screenshot of the new setting :)
i dont seem to actually have access to merge it, at the very least i cant see any button indicating to do so
Could you change the option label to something like API polling interval (Seconds)
?
Donβt worry about merging it, I thought PR authors could merge once approved, seems like not.
Iβll merge it early next week.
That was fast! Merging! π
have changed the setting label. thanks for the patience. still absolutely rolled by covid at the moment.
screenshot of the new setting :)
How do I add this to mine? I don't seem to have this option.
How do I add this to mine? I don't seem to have this option.
doesn't look like anyone's generated a release with this in - I'll try in the next couple of days on my fork if i can figure it out, else you can build it from source if you can install all the stuff.
Add a setting in Advanced Settings that allows the polling rate of currently playing and liked to be set.