dvx / lofi

πŸŽ΅πŸ”‰ A mini Spotify player with WebGL visualizations.
http://lofi.rocks
MIT License
1.21k stars 68 forks source link

Adjustable Refresh Rate #309

Closed Yayroos closed 9 months ago

Yayroos commented 9 months ago

Add a setting in Advanced Settings that allows the polling rate of currently playing and liked to be set.

Yayroos commented 9 months ago

308 #177 #234 #201 - fix and/or workaround for all these (and any any others about the API Throttling/constant calls) Allows the frequency to be set in Advanced Settings to your preference (default is current behaviour, currently playing every second)

stamoun commented 9 months ago

Many thanks for your contribution! πŸ™

However, please do not include styling change in an MR, follow the current ones (e.g. use single quotes and not double quotes).

Styling change could be done in a separate MR through an automatic process (much easier to review). I should set these for the whole project so that there's not ambiguity...

Yayroos commented 9 months ago

Will do - friend was helping me sort out the git stuff and applied the prettier formatting defaults so everything got rearranged.

stamoun commented 9 months ago

Will do - friend was helping me sort out the git stuff and applied the prettier formatting defaults so everything got rearranged.

No worries, I need a more exhaustive eslint config file (including prettier styling)

Yayroos commented 9 months ago

Have reverted all those other files - this should just be the files i touched to actually add the feature

stamoun commented 9 months ago

Good stuff, I'll let you merge it @Yayroos πŸš€

stamoun commented 9 months ago

Forgot to add something but I'm sure it's fine...

When you modify the UI in any way, please post a screenshot of your modification (the extra setting in this case). You can still go ahead and merge this PR though.

Yayroos commented 9 months ago

i'll grab a screenshot today!

thanks for your quick responses and patience.

stamoun commented 9 months ago

i'll grab a screenshot today!

thanks for your quick responses and patience.

No worries, it's fun to see contributions to Lofi :) Also, thanks for being understanding. I hope you learned a bit during this review.

Yayroos commented 9 months ago

i will get to this - i got covid and sitting up for more than 5 minutes hurts

stamoun commented 9 months ago

i will get to this - i got covid and sitting up for more than 5 minutes hurts

No worries, I can squash and merge for you, but I want you to press that button. I don't know why but it's a good feeling to press that Squash and merge button :)

This code isn't going anywhere.

Yayroos commented 9 months ago

i'll do it, maybe this afternoon if i can actually use my proper laptop. I'm keen to do it, i just can't think straight or sit up properly at the moment, so it'll have to wait until i shake the damn virus

Yayroos commented 9 months ago

lofi new setting refresh time screenshot of the new setting :)

Yayroos commented 9 months ago

i dont seem to actually have access to merge it, at the very least i cant see any button indicating to do so

stamoun commented 9 months ago

Could you change the option label to something like API polling interval (Seconds)?

Don’t worry about merging it, I thought PR authors could merge once approved, seems like not.

I’ll merge it early next week.

stamoun commented 9 months ago

That was fast! Merging! πŸš€

Yayroos commented 9 months ago

have changed the setting label. thanks for the patience. still absolutely rolled by covid at the moment.

ccxxv commented 2 months ago

lofi new setting refresh time screenshot of the new setting :)

How do I add this to mine? I don't seem to have this option.

Yayroos commented 2 months ago

How do I add this to mine? I don't seem to have this option.

doesn't look like anyone's generated a release with this in - I'll try in the next couple of days on my fork if i can figure it out, else you can build it from source if you can install all the stuff.