search

dvyukov / relacy

Automatically exported from code.google.com/p/relacy
Other
208 stars 32 forks source link

Fix atomic cv pointer stores #17

Closed ccotter closed 2 months ago

ccotter commented 2 months ago

The new test code fails to compile without proper handling for cv qualified atomic pointer types.

ccotter commented 2 months ago

Note: I wasn't sure how to actually build the test/main.cpp test file which includes memory_order.hpp. It's not part of the default Makefile. When I tried to compile test/main.cpp with GCC 11 (defaults -std=c++17), I got various errors about conflicting types for std/rl::memory_order with the former coming from <atomic>. I did verify the test code compiles by copy/pasting it into the ntest test which is built by the Makefile.

dvyukov commented 2 months ago

Hi Chris, Thanks for fixing these issues. I don't have much memory of how things work here. But the code changes look plausible, so I will trust you on this.