Fix memory related bugs

dvyukov / relacy

Automatically exported from code.google.com/p/relacy

Other

208 stars 32 forks source link

Fix memory related bugs #24

Closed ccotter closed 1 month ago

ccotter commented 1 month ago

Use debug_info for data members instead of debug_info_param (which is a reference). Caught by ASAN.
Supply C++14 overloads for operator delete, which may be called by the standard library. Without these overloads, some deallocations are not intercepted by relacy, and can lead to malloc/free mismatches.

dvyukov commented 1 month ago

Use debug_info for data members instead of debug_info_param (which is a reference). Caught by ASAN.

I don't see this in the changes. Am I missing something? Have you forgot to add some files?

ccotter commented 1 month ago

I don't see this in the changes. Am I missing something? Have you forgot to add some files?

~I'm not sure where those changes went - I must have had an older version of mutex.hpp which had data members as debug_info_param. The latest version of the code doesn't have that though. I amended the commit message.~

Ah, ok, it was in the newly introduced unique_lock/lock_guard...