search

dvyukov / relacy

Automatically exported from code.google.com/p/relacy
Other
206 stars 32 forks source link

Build some examples on Linux #9

Closed strager closed 5 years ago

strager commented 5 years ago

Add a basic GNU Makefile which can build (make) and run (make check) two example programs on Linux (and possibly other POSIX-y platforms).

Also enable continuous integration with Travis CI [1] to catch mistakes in future commits.

[1] https://travis-ci.org/

dvyukov commented 5 years ago

Nice! This is beyond my makefile-foo and travis-foo, so I will ask some questions.

dvyukov commented 5 years ago

This builds only 1 test and 1 example for me. Is it intentional? Can we build all of them?

strager commented 5 years ago

This builds only 1 test and 1 example for me. Is it intentional?

Yes, this is intentional. I wanted to build just enough code to validate the makefile and Travis CI machinery.

Can we build all of them?

I had problems building most of the examples and tests on my machine. Many of the programs use relacy_std.hpp. relacy_std.hpp overrides names in the std namespace, and that breaks on my setup. (#2 looks related.)

I didn't try finding all of the programs which worked. I only picked the first program in tests/ and the first program in examples/ which worked.

We can extend list of tests and examples in future commits.

dvyukov commented 5 years ago

This builds only 1 test and 1 example for me. Is it intentional?

Yes, this is intentional. I wanted to build just enough code to validate the makefile and Travis CI machinery.

Can we build all of them?

I had problems building most of the examples and tests on my machine. Many of the programs use relacy_std.hpp. relacy_std.hpp overrides names in the std namespace, and that breaks on my setup. (#2 looks related.)

I didn't try finding all of the programs which worked. I only picked the first program in tests/ and the first program in examples/ which worked.

We can extend list of tests and examples in future commits.

Acknowledged.

dvyukov commented 5 years ago

Overall, if you make it a bit simpler by removing all knobs and .DELETE_ON_ERROR, I think I now understand it and ready to merge. Thanks

dvyukov commented 5 years ago

OK, let's go with this version. Thanks for bearing with me.

dvyukov commented 5 years ago

Woohoo! We are green: https://github.com/dvyukov/relacy/blob/master/README.md

ChrisMThomasson commented 5 years ago

Wonderful! :^)

On Fri, Nov 30, 2018 at 1:25 AM Dmitry Vyukov notifications@github.com wrote:

Woohoo! We are green: https://github.com/dvyukov/relacy/blob/master/README.md

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dvyukov/relacy/pull/9#issuecomment-443143532, or mute the thread https://github.com/notifications/unsubscribe-auth/ANRPn-ccOgf1XywMWcfCC7qFqbBQcTRdks5u0PmhgaJpZM4Yv3rm .

oracleloyall commented 3 years ago

You can try!

------------------ Original ------------------ From: Dmitry Vyukov <notifications@github.com> Date: Fri,Nov 23,2018 8:55 PM To: dvyukov/relacy <relacy@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: Re: [dvyukov/relacy] Build some examples on Linux (#9)

This builds only 1 test and 1 example for me. Is it intentional? Can we build all of them?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.