dw-0 / kiauh

Klipper Installation And Update Helper
GNU General Public License v3.0
3.4k stars 492 forks source link

Theme install fails if any folder present in config folder #222

Closed jatson closed 2 years ago

jatson commented 2 years ago

Linux Distribution

Ubuntu 20.04.4 LTS (GNU/Linux 5.4.164-235 armv7l)

What happened

I have a folder inside my "klipper_config" folder called "archived" to store the old configuration files. This leads to a failure during automated mainsail theme install: the ".theme" folder will be placed into the subfolder. Please see the screen attached about the install log: image

What did you expect to happen

I would expect that the target directory is not any subdirectory inside the "klipper_config" folder but the folder itself

How to reproduce

Additional information

Running the following command will help to solve the problem and the theme will be able to run properly: "mv klipper_config/archived/.theme/ klipper_config/"

dw-0 commented 2 years ago

Hey, thanks for the report. I just pushed a fix to this issue. Feel free to update KIAUH and confirm if the issue has been resolved. In my tests, the themes now get correctly installed.

jatson commented 2 years ago

Hey, confirmed. Works like charm! Thanks for the quick fix!