search

dw-0 / kiauh

Klipper Installation And Update Helper
GNU General Public License v3.0
3.4k stars 492 forks source link

Install Mainsail or Fluidd without Moonraker #258

Closed marbocub closed 1 year ago

marbocub commented 2 years ago

Is your feature request related to a problem? Please describe

I am constructing a multi host Klipper environment by a backend host for multi instance Klippy and Moonraker, and a web only host for Mainsail and Fluidd.

I want to use KIAUH to install Mainsail or Fluidd, however, KIAUH need installed Moonraker before installing Mainsail or Fluidd. The Moonraker is unnessesary to install for the web only host.

Describe the solution you'd like

Do you have a plan to enable installing Mainsail or Fluidd without Moonraker?

Describe alternatives you've considered

May I send PR #247 or a similar improved version?

Additional information

No response

dw-0 commented 2 years ago

Hi! Sorry for the late reply, i actually planned to give you feedback in your PR. I just haven't had much time lately due to real life. Now i see that you already closed your PR, should i re-open it? I think the idea is good. Actually a thing a haven't considered yet that people want to do that. But it seems possible.

dw-0 commented 2 years ago

I briefly looked at the PR. I don't think it's required to change anything in regards to NGINX. Mainsail and (afaik) Fluidd both allow to connect to external Moonraker instances. So i think the only necessary step is to remove the restriction in KIAUH and in case of Mainsail, for instance storage the config.json has to be modified to use "browser".

marbocub commented 1 year ago

Sorry for the very late reply due to sickness. May I repost the PR without NGINX?

dw-0 commented 1 year ago

Resolved by https://github.com/th33xitus/kiauh/pull/347