search

dw-0 / kiauh

Klipper Installation And Update Helper
GNU General Public License v3.0
3.4k stars 491 forks source link

Ssh cloning #323

Closed viappidu closed 2 months ago

viappidu commented 1 year ago

Checking if cloning will be done via ssh

northrup commented 1 year ago

@viappidu is there a reason you'd want to introduce SSH based cloning? The potential problem I see with is that it would require users to have an SSH key generated for the user the process is running under in order to clone the repos versus https cloning of a public repo which requires no such setup.

viappidu commented 1 year ago

I understand your concerns, and you are right though I use private repositories and have already running agents with my keys. I actually can only ssh to my repositories...

On Mon, May 15, 2023, 9:21 PM John Northrup @.***> wrote:

@viappidu https://github.com/viappidu is there a reason you'd want to introduce SSH based cloning? The potential problem I see with is that it would require users to have an SSH key generated for the user the process is running under in order to clone the repos versus https cloning of a public repo which requires no such setup.

— Reply to this email directly, view it on GitHub https://github.com/th33xitus/kiauh/pull/323#issuecomment-1548439168, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKLJHTY337D6YGSW6M2NGLXGJ65PANCNFSM6AAAAAAWOMEWH4 . You are receiving this because you were mentioned.Message ID: @.***>

hg42 commented 6 months ago

here a reason you'd want to introduce SSH based cloning

I also happen to use my own local repo to combine multiple external sources. I could put them on github, but it's too special and usually it's temporary (e.g. when debugging, I change some lines and merge the other repos).

Users that use a git repo via ssh, will also know how to solve the key problem. Normal users are not affected.

Additionally there are several other possibilities, github isn't the only public git site, think of gitlab etc. I generally think, kiuah should not mess with the repo url at all.

dw-0 commented 2 months ago

This should be possible with KIAUH v6 which's alpha got released just a minute ago. So im closing this PR for now. Thanks anyways!