dw-0 / kiauh

Klipper Installation And Update Helper
GNU General Public License v3.0
3.38k stars 488 forks source link

After Switching Klipper Repo via KIAUH, Moonraker reports that the repo is invalid #341

Closed 4rianton closed 1 year ago

4rianton commented 1 year ago

Linux Distribution

RPi 4 - Bullseye

What happened

After changing Klipper installation to my fork (had to have changes for Neopixel) via KIAUH, it succeeded on the terminal, and things are functional on Mainsail too, but in Update Manager, it says that the Klipper installation is invalid.

What did you expect to happen

Expected Update_manager to see it as a valid Klipper Repo

How to reproduce

  1. Add a different klipper repo to the klipper_repos.txt
  2. switch the klipper repo using KIAUH
  3. check for updates on Mainsail (moonraker essentially)
  4. Klipper installation says "invalid"

Everything works as it should though.

Additional information

Screenshot 2023-05-19 at 21 24 37

Chunk from moonraker.log

2023-05-19 21:09:43,659 [shell_command.py:_check_proc_success()] - Command (git -C /home/pi/klipper rev-list --tags --max-count=1) successfully finished
2023-05-19 21:09:43,660 [git_deploy.py:log_repo_info()] - Git Repo klipper Detected:
Owner: <redacted>
Repository Name: klipper
Path: /home/pi/klipper
Remote: origin
Branch: master
Remote URL: https://github.com/<redacted>/klipper
Current Commit SHA: b1fb70a5b919fbf77b6efac00ddfc08ac4bf2066
Upstream Commit SHA: b1fb70a5b919fbf77b6efac00ddfc08ac4bf2066
Current Version: ?
Upstream Version: ?
Is Dirty: False
Is Detached: False
Commits Behind: 0
Tag Data: {}
Bound Repo: None
Diverged: False
2023-05-19 21:09:43,660 [base_deploy.py:log_info()] - Application klipper: Channel: dev, Need Channel Update: False
2023-05-19 21:09:43,660 [base_deploy.py:log_info()] - Application klipper: Repo validation checks failed:
Unofficial remote url: https://github.com/<redacted>/klipper
2023-05-19 21:09:43,660 [base_deploy.py:log_info()] - Application klipper: Updates on repo disabled
2023-05-19 21:09:47,009 [update_manager.py:_get_remote_version()] - Github client Info Received:
Repo: mainsail
Local Version: v2.5.1
Remote Version: v2.5.1
Pre-release: False
url: https://github.com/mainsail-crew/mainsail/releases/download/v2.5.1/mainsail.zip
size: 1991346
Content Type: application/zip
2023-05-19 21:09:50,373 [update_manager.py:_get_remote_version()] - Github client Info Received:
Repo: fluidd
Local Version: v1.24.0
Remote Version: v1.24.0
Pre-release: False
url: https://github.com/fluidd-core/fluidd/releases/download/v1.24.0/fluidd.zip
size: 3451126
dw-0 commented 1 year ago

https://moonraker.readthedocs.io/en/latest/installation/#debug-options-for-developers