search

dw-0 / kiauh

Klipper Installation And Update Helper
GNU General Public License v3.0
3.4k stars 491 forks source link

KIAUH clears the scrollback buffer every time you use a menu option. #396

Closed LoganDark closed 2 months ago

LoganDark commented 1 year ago

Linux Distribution

Raspberry Pi OS (Legacy) Lite (Debian Bullseye)

What happened

I wanted to look at some of the things KIAUH did, but the process of exiting the script caused the entire scrollback buffer to get cleared in my terminal, so now I can't see any history.

What did you expect to happen

KIAUH should only clear the current screen, not the entire terminal history.

How to reproduce

Install something, see tons and tons of output, see you can scroll back up. Use the menu to exit the script, see that all the history has disappeared.

Additional information

Using WSL through Windows Terminal.

dw-0 commented 2 months ago

"Clearing the screen" via clear in bash results in the scrollback buffer to be cleared, that it whats happening when entering the main menu again after any steps done. This does not happen anymore with KIAUH v6 whichs alpha got released a moment ago.

LoganDark commented 2 months ago

"Clearing the screen" via clear in bash results in the scrollback buffer to be cleared

I know; one can use clear -x instead which clears the screen but not the scrollback :) not sure if this is how you fixed it, but if it is fixed, thank you!

dw-0 commented 2 months ago

Well, the "fix" is to not clear anymore at all currently :)

dw-0 commented 2 months ago

I did not know about clear -x, this looks actually like a neat way of doing it in the future. Thanks for the hint!

LoganDark commented 2 months ago

Well, the "fix" is to not clear anymore at all currently :)

considering the issue was that scrollback was being cleared, simply not clearing the screen would indeed be a fix!

I did not know about clear -x, this looks actually like a neat way of doing it in the future. Thanks for the hint!

❤️