search

dw-0 / kiauh

Klipper Installation And Update Helper
GNU General Public License v3.0
3.3k stars 474 forks source link

fix: OctoPrint logo in README.md #423

Closed jneilliii closed 8 months ago

HumbleDeer commented 8 months ago

I've got an alt/dupe of this, but with the logo from the docs directory: https://github.com/dw-0/kiauh/pull/424

dw-0 commented 8 months ago

I wonder which solution would be better/more future-proof. Im not sure why the image disappeared, not sure what has changed on their side.

I think we will take this approach for now. So thank you for your (both) contributions!

jneilliii commented 8 months ago

I'm not exactly sure what the camo link is from, but shows as how it's linked on the readme in the repo. For direct link to github content I would probably use https://github.com/OctoPrint/OctoPrint/blob/master/docs/images/octoprint-logo.png?raw=true or direct from the website maybe https://octoprint.org/assets/img/logo.png

dw-0 commented 8 months ago

Honestly im not sure why i decided for the camo link in the past 😅 maybe wasn't the best idea. If it breaks again, we should rather go for one of the other links.

HumbleDeer commented 8 months ago

For direct link to github content I would probably use https://github.com/OctoPrint/OctoPrint/blob/master/docs/images/octoprint-logo.png?raw=true

You can find a solution implementing this in the PR I made. It doesn't use the raw parameter, but GitHub handles that gracefully. I obtained the nonraw link through GitHub's methods of obtaining the permalink.

I also think using this link is better, because it's less likely to get purged from GitHub's CDN servers. The camo links are CDN meta-links.

dw-0 commented 8 months ago

I also think using this link is better, because it's less likely to get purged from GitHub's CDN servers. The camo links are CDN meta-links.

Thank you for the info @HumbleDeer, are you willing to reopen your PR, update it if necessary and we merge it afterwards?

HumbleDeer commented 8 months ago

I also think using this link is better, because it's less likely to get purged from GitHub's CDN servers. The camo links are CDN meta-links.

Thank you for the info @HumbleDeer, are you willing to reopen your PR, update it if necessary and we merge it afterwards?

Sure!