search

dw-0 / kiauh

Klipper Installation And Update Helper
GNU General Public License v3.0
3.4k stars 491 forks source link

refactor(Mobileraker): update Mobileraker's companion installer script #431

Closed Clon1998 closed 9 months ago

Clon1998 commented 9 months ago

With the PR https://github.com/Clon1998/mobileraker_companion/pull/77 I am switching to the installer of OE. Therefore, an update to the mobileraker.sh is required. I did not touch the removal code as it is pretty similar to what I am doing with the installer anyway.

Please wait with a merge on the PR until https://github.com/Clon1998/mobileraker_companion/pull/77 is ready

Clon1998 commented 9 months ago

Especially with regards to #428, just changing the install script section and keeping the removal section is fine.

dw-0 commented 9 months ago

Looks good to me :) Thank you!

Clon1998 commented 9 months ago

Looks good to me :) Thank you!

Fyi, this will break kiauh for mobileraker until I merged https://github.com/Clon1998/mobileraker_companion/pull/77

dw-0 commented 9 months ago

Ooops, damn, i didn't read the last paragraph of your first post. Sorry!

dw-0 commented 9 months ago

I merged a revert PR to prevent that breaking change. Please notify me once that change is merged on your side and it can go live in KIAUH.