No-fields templates

[GoogleCodeExporter]

Do not import templates that have no fields whatsoever: no text, no image.
They only cause trouble later on.
Admins will be better off creating them directly in Magento.

Original issue reported on code.google.com by zetapri...@gmail.com on 29 Jan 2010 at 1:18

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 29 Jan 2010 at 10:47

• Added labels: Delivery-2010-01-31

[GoogleCodeExporter]

Original comment by Anatoly....@gmail.com on 4 Feb 2010 at 1:58

• Changed state: Finished

[GoogleCodeExporter]

New code is in 1.7.0.0beta4 (installed in magedev)

Original comment by Anatoly....@gmail.com on 4 Feb 2010 at 2:19

• Changed state: ToTest

[GoogleCodeExporter]

Templates with no fields are not being imported.
Uploaded this template to the w2p site:
http://magento.zetaprints.com/?page=template;TemplateID=A0B99187-675E-4D28-80FF-
31C8B8B26D4E

Ran the "Template sync" profile and got a notification in the log that the 
template
was not changed.

Original comment by agur...@gmail.com on 4 Feb 2010 at 6:49

• Changed state: TestOK

Attachments:

• no_fields_template.png

[GoogleCodeExporter]

Here we go. Something we haven't thought about.
If an existing template is updated with a version with no fields it needs to be
deleted with all the consequences of deleting a template (see #114).
The message should say: "Template #### has no variable fields. [action]", where
action is what you do with deleted templates.

If a template is a new template and has no fields you give this message:
"Template ##### has no variable fields. Ignored."

It's good you are highlighting it.

Original comment by zetapri...@gmail.com on 8 Feb 2010 at 12:50

• Changed state: MoreWork

[GoogleCodeExporter]

Original comment by Anatoly....@gmail.com on 9 Feb 2010 at 6:13

• Changed state: Finished

[GoogleCodeExporter]

Code is updated in 1.7.0.0beta7 (uploaded to magedev)

Original comment by Anatoly....@gmail.com on 9 Feb 2010 at 10:37

• Changed state: ToTest

[GoogleCodeExporter]

I added a new template to the w2p catalog, ran the profiles and got a product 
from
it. Then I re-uploaded the template, changed the config settings for deleted
templates to "move to category..." and ran the Sync profile again.

Got a log like in the screenshot. Template was moved to the specified category 
(FSBO
yard signs) as requested in comment 5, but the log only said "... was deleted".

http://www.zetaprints.com/magedev/index.php/realestate-signs/fsbo-yard-signs/bla
nk-template-ii.html

Original comment by agur...@gmail.com on 9 Feb 2010 at 4:37

• Changed state: MoreWork

Attachments:

• blank_template.png

[GoogleCodeExporter]

See last lines in the log, there should be a message about moving product to 
the 
specified category.

Original comment by Anatoly....@gmail.com on 9 Feb 2010 at 7:56

• Changed state: ToTest

[GoogleCodeExporter]

1. Uploaded a template with fields. Ran the profiles and created the product 
for it.
2. Re-uploaded the same template without variable fields and re-ran the profiles
(config set to "move to category").
3. The final log entry contains the template movement details
(no-fields_template_moved_to_category.png).

This part works OK.

Additional steps:
4. Re-uploaded the same template again, this time with variable fields back and 
ran
the profiles.
5. Template Sync profile log says that a template is successfully added.
6. Product creation log throws up an err:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-83' 
for key
1 (re-uploaded_no-field_template_prod_creation.png)

Q: What should we do in this situation?

Original comment by agur...@gmail.com on 10 Feb 2010 at 3:00

• Changed state: QnA

Attachments:

• no-fields_template_moved_to_category.png
• re-uploaded_no-field_template_prod_creation.png

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 10 Feb 2010 at 6:07

• Changed state: MoreWork

[GoogleCodeExporter]

Original comment by Anatoly....@gmail.com on 2 Mar 2010 at 7:28

• Changed state: ToTest

[GoogleCodeExporter]

1. Uploaded a template with fields. Ran the profiles and created the product 
for it.
http://www.zetaprints.com/magedev/index.php/email-signatures/no-fields-ii.html
2. Re-uploaded the same template without variable fields and re-ran the profiles
(config set to "move to category").
3. The final log entry contains a red SQL err (no_fields_template_1.png)

Original comment by agur...@gmail.com on 2 Mar 2010 at 11:21

• Changed state: MoreWork

Attachments:

• no_fields_template_1.png

[GoogleCodeExporter]

These are the files I used.

Original comment by agur...@gmail.com on 3 Mar 2010 at 8:49

Attachments:

• with_fields.cdr
• no_fields.cdr

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 8 Mar 2010 at 9:15

• Added labels: Delivery-2010-03-09
• Removed labels: Delivery-2010-01-31

[GoogleCodeExporter]

Original comment by Anatoly....@gmail.com on 9 Mar 2010 at 10:10

• Changed state: Finished

[GoogleCodeExporter]

The bug is fixed in 1.8.0.0beta11 (installed on magedev)

Original comment by Anatoly....@gmail.com on 9 Mar 2010 at 6:05

• Changed state: ToTest

[GoogleCodeExporter]

1. Uploaded a template and created a product:
http://www.zetaprints.com/magedev/index.php/email-signatures/no-fields-iii.html

2. Re-uploaded the same template without variable fields and re-ran the profiles
(config set to "move to category").

3. Got the same log red warning at the bottom (log_warning.png)

Original comment by agur...@gmail.com on 9 Mar 2010 at 8:59

• Changed state: MoreWork

Attachments:

• log_warning.png

[GoogleCodeExporter]

Original comment by Anatoly....@gmail.com on 10 Mar 2010 at 8:39

• Changed state: Finished

[GoogleCodeExporter]

The bug is fixed in 1.8.0.0rc1 (installed on magedev)

Original comment by Anatoly....@gmail.com on 11 Mar 2010 at 9:41

• Changed state: ToTest

[GoogleCodeExporter]

1. Tested the issue on the existing template I used for testing before. Ran the
profile and got no err msg in the log. The template was moved to the assigned
category. Deleted it from the w2p site afterwords.

2. Uploaded a new template and created a new product:
http://www.zetaprints.com/magedev/index.php/email-signatures/blank-template-iv.h
tml

3. Re-uploaded the same template with no variable fields and ran the Sync 
profile
again. Log had no SQL err msg (blank_template_log.png) and the template was 
moved to
the destination category (FSBO signs):
http://www.zetaprints.com/magedev/index.php/realestate-signs/fsbo-signs.html

Original comment by agur...@gmail.com on 11 Mar 2010 at 1:55

• Changed state: TestOK

Attachments:

• blank_template_log.png

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 12 Mar 2010 at 7:18

• Changed state: Done