dw250100785 / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Input fields caching #119

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
We need to pre-populate text and image fields from the user cache.

Magento needs to keep track of the 100 recently used text fields and 50
recently used images. The values need to be stored as name-value pairs
where the field name is the key and the user input/selection is the value.
The keys in the cache are unique.

This cache needs to be stored for the lifetime of the user account.

It should behave like a stack. When 200 fields limit is reached the oldest
pair is purged. The same applies to images.

When a user gets a new template form the fields should be prepopulated with
values from the cache. 
 * text fields have values
 * images selected
 * colors selected

If a user clears a field it should remove the value from the cache.
The cache is updated only when the user requests preview generation.

In some cases field text can be very long. Make sure there is no
performance penalty. There should be no noticeable performance difference
between a new user and an existing user with a big cache.

Original issue reported on code.google.com by zetapri...@gmail.com on 1 Feb 2010 at 8:43

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 10 Feb 2010 at 5:41

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 19 Feb 2010 at 1:20

GoogleCodeExporter commented 9 years ago
New code is in 1.8.0.0beta2 (installed on magedev)

Original comment by Anatoly....@gmail.com on 19 Feb 2010 at 7:47

GoogleCodeExporter commented 9 years ago
I can't access any products! I get a 404 page. Did you delete the templates 
from the
database for testing issue 135? I posted a comment there as well, though we were
suppose to remove all products from /mageimage/. I don't know if I should 
delete the
products or is this a bug?

Original comment by agur...@gmail.com on 21 Feb 2010 at 2:09

GoogleCodeExporter commented 9 years ago
This was bug in r539

Original comment by k.safro...@gmail.com on 21 Feb 2010 at 3:00

GoogleCodeExporter commented 9 years ago
Please, prepare the site for testing.

Original comment by zetapri...@gmail.com on 21 Feb 2010 at 6:16

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 21 Feb 2010 at 6:16

GoogleCodeExporter commented 9 years ago
This is not bug in r539, definitely.
The problem is with XSLT lib.

Original comment by Anatoly....@gmail.com on 22 Feb 2010 at 4:32

GoogleCodeExporter commented 9 years ago
Workaround was added to 1.8.0.0beta3 (installed on magedev)

Original comment by Anatoly....@gmail.com on 22 Feb 2010 at 10:30

GoogleCodeExporter commented 9 years ago
1.8.0.0beta4 is installed on magedev (Beta3 contained errors).
Please, test it.

Original comment by Anatoly....@gmail.com on 22 Feb 2010 at 12:01

GoogleCodeExporter commented 9 years ago
Tested OK for the most part. Cache remembers the user input and choices both for
anonymous users and registered ones. I entered values for all the fields, 
uploaded
images, picked colors and regenerated the preview. Refreshed the page and got 
the
latest values populated in the fields. Left the page and went to another 
template
with same field names, the identical fields were also populated. This works ok.
Issues:
1. The icon in front of the image fields is not checked and shows the ! icon
(selected_image.png) even though the image is selected in the list. I think 
that the
user should see that field as "dealt with" since the input is remembered.
2. Seems like the user input is not cached as per account. I entered values for 
all
the fields, uploaded images, picked colors and regenerated the preview as a
registered user in FF. Then I logged in the same account on a different browser 
(IE),
the fields were empty - my input is not cached as a user.

Original comment by agur...@gmail.com on 22 Feb 2010 at 1:15

Attachments:

GoogleCodeExporter commented 9 years ago
I hope it's not cached on the client ?

Original comment by zetapri...@gmail.com on 24 Feb 2010 at 7:33

GoogleCodeExporter commented 9 years ago
Nope

Original comment by Anatoly....@gmail.com on 24 Feb 2010 at 8:52

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 26 Feb 2010 at 2:29

GoogleCodeExporter commented 9 years ago
New code is in 1.8.0.0beta6

Original comment by Anatoly....@gmail.com on 28 Feb 2010 at 10:53

GoogleCodeExporter commented 9 years ago
Please see issue #146

Original comment by agur...@gmail.com on 28 Feb 2010 at 1:30

GoogleCodeExporter commented 9 years ago
Needs to be re-tested after resolving issue #146 but here is the other part:

Cache works. Tried it on a template logged in and out. After editing a template
logged in through FF, I logged in as the same customer through IE as well and 
got the
fields populated same way. The system cached my input and re-populated the 
fields in
the different browser for all templates with the same field name. This works OK.

1. The icon in front of the image fields is not checked and shows the ! icon 
even
though the image is selected in the list. I think that the user should see that 
field
as "dealt with" since the input is remembered. I posted this issue in a previous
comment, was it accepted or is this the way it should be?

Original comment by agur...@gmail.com on 28 Feb 2010 at 8:19

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 2 Mar 2010 at 7:00

GoogleCodeExporter commented 9 years ago
Cache works. The previous issue remains though. 

The icon in front of an image field that has the image selection cached should 
be the
green "check" icon, not the yellow "!" one.

Please fix it.

Original comment by agur...@gmail.com on 2 Mar 2010 at 1:03

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 3 Mar 2010 at 6:55

GoogleCodeExporter commented 9 years ago
Fix is in 1.8.0.0beta8 (installed on magedev)

Original comment by Anatoly....@gmail.com on 3 Mar 2010 at 3:06

GoogleCodeExporter commented 9 years ago
Caching works. Checked icon appears only for images that are cached, the rest 
of the
image fields (un-cached) are flagged for attention.

Only one small issue remains for this part of the code. Can you make the cached 
image
appear first in the image library? Doesn't have to be first, the library could 
just
be auto-scrolled to the position of the selected image.

Original comment by agur...@gmail.com on 3 Mar 2010 at 3:38

Attachments:

GoogleCodeExporter commented 9 years ago
Scrolling is another issue. It was created by you, see issue #144

Original comment by Anatoly....@gmail.com on 3 Mar 2010 at 3:52

GoogleCodeExporter commented 9 years ago
Scrolling is implemented in 1.8.0.0beta9 (installed on magedev) 

Original comment by Anatoly....@gmail.com on 3 Mar 2010 at 5:12

GoogleCodeExporter commented 9 years ago
Sorry, my bad. You're right, we have a separate issue for this.

Original comment by agur...@gmail.com on 3 Mar 2010 at 5:31

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 4 Mar 2010 at 4:03