search

dw250100785 / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Image fields width #88

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Image field boxes are not as wide as the text fields
(image_fields_width_bef.png)

Make them same width 
(image_fields_width_aft.png)

Original issue reported on code.google.com by agur...@gmail.com on 5 Jan 2010 at 7:29

Attachments:

GoogleCodeExporter commented 9 years ago 
Also, add 15px of empty space between the text and image fields. At the moment 
they
are too close to each other. At first glance, one might think that the last text
field is extended somehow and holds additional options.

Screenshot attached: image_fields_space.png

Original comment by agur...@gmail.com on 5 Jan 2010 at 7:38

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 6 Jan 2010 at 7:37

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 19 Jan 2010 at 5:33

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 22 Apr 2010 at 6:36

GoogleCodeExporter commented 9 years ago 
If we need to rebuild the extension to make it work then let's rebuild it.
It's got to be fixed.

Original comment by ad...@zetaprints.com on 13 Apr 2011 at 7:40

GoogleCodeExporter commented 9 years ago 
As I said a long time ago text fields are wider because of browser but not our 
CSS.

We can use JS to make text fields width as a width of image fields.

Original comment by Anatoly....@gmail.com on 15 Apr 2011 at 6:39

GoogleCodeExporter commented 9 years ago 
how would JS help?

Original comment by ad...@zetaprints.com on 15 Apr 2011 at 8:36

GoogleCodeExporter commented 9 years ago 
I can take width of container or image field in px and set it to text fields.

Original comment by Anatoly....@gmail.com on 18 Apr 2011 at 4:37

GoogleCodeExporter commented 9 years ago 
OK, if yo think this is the only way then let's do it.
I don't like the sound of it, though.

Original comment by ad...@zetaprints.com on 18 Apr 2011 at 8:24

GoogleCodeExporter commented 9 years ago

Original comment by Anatoly....@gmail.com on 20 Apr 2011 at 8:41

GoogleCodeExporter commented 9 years ago 
Diffs: http://code.google.com/p/magento-w2p/source/detail?r=1562

> Also, add 15px of empty space between the text and image fields.
> At the moment they are too close to each other. At first glance,
> one might think that the last text field is extended somehow
> and holds additional options.

Diff: http://code.google.com/p/magento-w2p/source/detail?r=1563

Tested in Tested in IE7, IE8, FF 3.5, Chrome 6, Opera 10, Opera 11 and Safari 5

Original comment by Anatoly....@gmail.com on 22 Apr 2011 at 2:51

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 23 Apr 2011 at 4:09

GoogleCodeExporter commented 9 years ago 
Atanas, please, test it with 1.9.0.0rc3 release.

Original comment by Anatoly....@gmail.com on 25 Apr 2011 at 10:38

GoogleCodeExporter commented 9 years ago 
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.0.0rc3 (beta) 
in all browsers.

The field length and spacing is as it should be. I did notice some other 
differences in the fields, not sure if they are caused by this issue's fix.

http://d1.zetaprints.com/mageimage/index.php/mageimg-01/1pg-template.html

1. The upload image field is smaller compared to the way it was before. It is 
supose to be as high as the buttons (red arrow in image_field.png).

2. The small type text (blue arrow in image_field.png) is smaller then is was 
before as well.

3. Also, I can't upload images to make sure the fields don't fall apart when 
more tabs (ex. My images) appear.

Original comment by agur...@gmail.com on 26 Apr 2011 at 12:11

Attachments:

GoogleCodeExporter commented 9 years ago 
If this issue is a show stopper for the release, roll it back, get the rest out.

Image uploading was probably early signs of the outage.

Original comment by ad...@zetaprints.com on 27 Apr 2011 at 1:05

GoogleCodeExporter commented 9 years ago 
> 1. The upload image field is smaller compared to the way it was before.
> It is supose to be as high as the buttons (red arrow in image_field.png).

Fixed. Diffs: http://code.google.com/p/magento-w2p/source/detail?r=1584

Tested in Tested in IE7, IE8, FF 3.5, Chrome 6, Opera 10, Opera 11 and Safari 5

> 2. The small type text (blue arrow in image_field.png) is smaller
> then is was before as well.

I made it smaller to fit the message into parent box.

> 3. Also, I can't upload images to make sure the fields don't fall apart
> when more tabs (ex. My images) appear.

There was problems with ZP

Original comment by Anatoly....@gmail.com on 2 May 2011 at 12:55

GoogleCodeExporter commented 9 years ago 
Please, use 1.9.0.0rc4 for testing

Original comment by Anatoly....@gmail.com on 5 May 2011 at 7:30

GoogleCodeExporter commented 9 years ago 
Tested on /mageimage/
web_to_print_store_incl_theme   1.9.0.0rc4 (beta)

Original comment by agur...@gmail.com on 5 May 2011 at 8:35

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 5 May 2011 at 10:13

GoogleCodeExporter commented 9 years ago

Original comment by ad...@zetaprints.com on 5 May 2011 at 10:16