dwaan / homebridge-adb

Homebridge script to control remote ADB enabled Android device
MIT License
76 stars 15 forks source link

v1.5.2, v1.5.3 breaks Homebridge #74

Closed Adrian-1994 closed 2 years ago

Adrian-1994 commented 2 years ago

I’m getting this error after updating..

ReferenceError: stderr is not defined at /us/local/lib/node modules/homebridge-adb/index.js:893:51 at /us/local/lib/node modules/homebridge-adb/index.js:940:20 at ChildProcess.exithandler (node:child process: 406:5) at ChildProcess.emit (node:events:520: 28) at maybeClose (node: internal/child process: 1092:16) at Socket. (node: internal/child process:451:11) at Socket.emit (node:events:520:28) at Pipe. (node:net: 687:12)

Not only does the plug-in not work, but Homebridge becomes non-functional on these versions. Downgrading back to v1.5.0 restores functionality.

Aekung commented 2 years ago

Also have the same problem. Reversing back to 1.5.2 also breaks the Homebridge as well. The best thing I could do now is to temporary disable the plugin.

Note that it's been fine up until 1.5.2. I have just decided to update it to 1.5.3 today and found that it breaks Homebridge.

dwaan commented 2 years ago

Thank you for the report. Still working with that bugs that wasn’t appeared when I tested it few days ago.

Edit: I'm unpublishing 1.5.2 and 1.5.3

dwaan commented 2 years ago

I'm currently publishing a beta version of the plugins for testing, as it contain multiple enhancements that may or may not break the connection to the android device (and hopefully not breaking homebridge). Please consider trying it and let me know if it working in your installation.

Adrian-1994 commented 2 years ago

So far, so good! Both the plugin and Homebridge are working with the beta version you published. Thank you for the fast update!

Aekung commented 2 years ago

The beta works for me so far as well.

Thank you very much.