search

dwadden / dygiepp

Span-based system for named entity, relation, and event extraction.
MIT License
573 stars 120 forks source link

How are the equations in the paper expressed in the code? #107

Closed jeremytanjianle closed 1 year ago

jeremytanjianle commented 1 year ago

Hi,

Loving the work. Am still using this for years. Can I ask where is the propagation for events expressed in the code? (specifically, the equations (2,3,4) in appendix B of the paper)

Firstly, is it correct to say that this formula happens in _compute_argument_scores? I'm confused because in the code V seems to be the output of _compute_argument_scores whereas in the paper it is the input. image

Secondly, where does equation (3) and (4) take place in the code? I may have missed it, but I can't find the gating functions. image image

Thanks very much.

dwadden commented 1 year ago

Hi,

I'm glad the code has been helpful!

I'm looking through the code now and it looks like coreference propagation is implemented here, but relation propagation and event propagation aren't implemented in the "release" version of the code.

The reason was that, in the paper, we found that relation and event prop didn't really help, so we decided to simplify the code and get rid of these options. But event prop is available on the emnlp-2019 branch. Let me know if you've got questions about this.