Adds unit test and span based entities to spacy interface

e3oroush commented 2 years ago

Hi
I just added the unit test and span based entities for the spaCy interface, discussed #81

dwadden commented 2 years ago

Thanks for the test! A couple minor things before merging:

Run a code formatter over the submitted files. I unfortunately never set a consistent convention for this. Black is one good option, but any formatter is fine.
In the Jupyter notebook demo, the fourth detected entity is a single newline. Can you confirm that this is the result of a bad DyGIE prediction, not a mistake in piping the DyGIE output into Spacy?
Also in the notebook, can you convert the line text = ""Title: VocGan... into multiple lines for readability?

After that, I think we're good to merge.

e3oroush commented 2 years ago

Those were new line characters. I simply preprocessed the text to get rid of them.
I think I did all the items you asked in this PR. :smiling_face_with_tear:

dwadden commented 2 years ago

Works for me. Merging. Thanks again for adding this!

e3oroush commented 2 years ago

No problem at all. Glad that it's useful.

dwadden / dygiepp

Adds unit test and span based entities to spacy interface #86