dwaite / cookiejar

Manage client-side HTTP cookies in Ruby
BSD 2-Clause "Simplified" License
42 stars 69 forks source link

Multiple warnings under Ruby 1.9.2-p0. #1

Closed postmodern closed 13 years ago

postmodern commented 14 years ago

I'm getting multiple warnings under Ruby 1.9.2-p0:

/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/cookie_validation.rb:278: warning: (...) interpreted as grouped expression
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/cookie_validation.rb:294: warning: ambiguous first argument; put parentheses or even spaces
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/cookie_validation.rb:385: warning: ambiguous first argument; put parentheses or even spaces
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/jar.rb:128: warning: mismatched indentations at 'end' with 'def' at 124
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/jar.rb:142: warning: mismatched indentations at 'end' with 'def' at 134
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/jar.rb:153: warning: `*' interpreted as argument prefix
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/jar.rb:154: warning: `*' interpreted as argument prefix
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/jar.rb:155: warning: mismatched indentations at 'end' with 'def' at 150
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/jar.rb:224: warning: mismatched indentations at 'end' with 'if' at 220
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/jar.rb:267: warning: mismatched indentations at 'end' with 'unless' at 260
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/jar.rb:273: warning: mismatched indentations at 'end' with 'if' at 251
/home/hal/.rvm/gems/ruby-1.9.2-p0/gems/cookiejar-0.3.0/lib/cookiejar/jar.rb:280: warning: useless use of a variable in void context
dwaite commented 13 years ago

I believe I corrected the warnings given by 1.9.2, although I do not know what options you used to trigger them.