dwaite / cookiejar

Manage client-side HTTP cookies in Ruby
BSD 2-Clause "Simplified" License
42 stars 69 forks source link

cookiejar 0.3.1 is packaged with incorrect file permissions in gem #13

Closed davidzhao closed 10 years ago

davidzhao commented 10 years ago

The latest version is showing file perms of 600 instead of 644 for all files within the gem. This creates a problem when people install gems as root into /usr/local/lib/ruby, and then try to load it with another user on the system.

0.3.0 is packaged correctly. something had changed in the last version

/usr/local/lib/ruby/gems/2.1.0/gems/cookiejar-0.3.1$ ls -l
total 24
-rw------- 1 root root  363 Feb 19 01:19 contributors.json
drwxr-xr-x 3 root root 4096 Feb 19 01:19 lib
-rw------- 1 root root 1320 Feb 19 01:19 LICENSE
-rw------- 1 root root  717 Feb 19 01:19 Rakefile
-rw------- 1 root root  670 Feb 19 01:19 README.markdown
drwxr-xr-x 2 root root 4096 Feb 19 01:19 spec
/usr/local/lib/ruby/gems/2.1.0/gems/cookiejar-0.3.1$ ls -l ../cookiejar-0.3.0
total 8
drwxr-xr-x 3 root root 4096 Jan  9 06:54 lib
drwxr-xr-x 2 root root 4096 Jan  9 06:54 test
flauwekeul commented 10 years ago

:+1: My collegue discovered this same issue recently too.

jvanbaarsen commented 10 years ago

I tried repackaging the gem, and install it locally, that will fix the issue. @dwaite Can you please repack and republish the gem?

kevinslin commented 10 years ago

Ran into the same issue using em-http-request gem since it uses cookiejar as a dependency and now fails on require

Fetching the gem and running the following should fix it

cd cookiejar
sudo chmod -R a+r lib
gem build cookie-jar.gemspec
gem push cookie-jar-0.3.1.gem
davidzhao commented 10 years ago

Any updates here? It'd be a huge help if the maintainer could simply repackage and bump the version.

alain75007 commented 10 years ago

Please update this project to fix this problem.

avitus commented 10 years ago

:thumbsup:

jvanbaarsen commented 10 years ago

@dwaite Please repackage the gem :) :+1:

ajb commented 10 years ago

:(

kornypoet commented 10 years ago

+1

ajb commented 10 years ago

Has anyone pinged @dwaite via email?

jvanbaarsen commented 10 years ago

@adamjacobbecker Please go ahead :smile:

ajb commented 10 years ago

Just pinged him via email. FWIW, it might be worth asking the maintainers of other libraries that depend on cookiejar to lock the version at 0.3.0.

dwaite commented 10 years ago

cookiejar 0.3.2 released to fix the issue. But now I'll be raising an issue with ruby gems ;-)

ajb commented 10 years ago

Amazing, thank you!

jvanbaarsen commented 10 years ago

@dwaite Thanks :-)