search

dwallet-labs / dwallet-network

dWallet Network, a composable modular signature network that is the home of dWallets. A dWallet is a noncollusive and massively decentralized signing mechanism, used as a building block by builders on other networks to add native multi-chain interoperability to any smart contract.
https://docs.dwallet.io
Other
40 stars 35 forks source link

chore (proof-mpc): Move `mpc-protocols` crate into `pera-core` #252

Closed ItayLevyOfficial closed 1 month ago

ItayLevyOfficial commented 2 months ago

We needed to do it to be able to inject the validators signature MPC logic into Pera while avoiding import cycles.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **dwallet-network-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/dwallet-labs-team/dwallet-network-docs/2sxJTMrdRDQhEeaJ7vHNh7NMrDvn)) | [Visit Preview](https://dwallet-network-docs-git-251-move-mpc-15e141-dwallet-labs-team.vercel.app) | | Oct 7, 2024 10:02am |
ycscaly commented 1 month ago

Why is this PR needed? why not change 244 so that the packages would be created correctly instead of creating something just to change it?

ItayLevyOfficial commented 1 month ago

Why is this PR needed? why not change 244 so that the packages would be created correctly instead of creating something just to change it?

Because two people already reviewed it and changing it would discard their comments. Refactor PRs, like this one, are common & quite clean