Even if you are happy with your score, please visit Gradescope and check for any comments I might have made.
Commits
Commit messages pretty good.
Some still needed a bit more detail, and so check for any comments.
Feature Branches
Do not make a branch from the end of a previous branch:
Don't make any edits, including to README.md on the main branch
Modular Code
Type conversions (int(), float()) will need to be tested in future assignments. So, do not use these functions in a function that also does I/O. Avoid:
In a function that does calculations that needs to be tested, avoid calling another function that does I/O.
def calculator():
weight = get_input()
weight = weight * 2.20462
# Do other calculations here
return answer
Make sure a function has a return so it can be tested.
def make_choice(input_value):
if input_value > 0:
print("You have a positive number.")
elif input_value < 0:
print("You have a negative number.")
else:
print("You have zero")
Since no return, this function could not be tested. This would be better:
def make_choice(input_value):
answer = ""
if input_value > 0:
answer = "You have a positive number."
elif input_value < 0:
answer = "You have a negative number."
else:
answer = "You have zero"
print(answer)
return answer
Ranges
Be careful about continuous range checking
<=29.9 instead of <30
BMI Calculator Feedback
Commits
Feature Branches
README.md
on themain
branchModular Code
int()
,float()
) will need to be tested in future assignments. So, do not use these functions in a function that also does I/O. Avoid:Since no return, this function could not be tested. This would be better:
Ranges
<=29.9
instead of<30
Questions on Unit Testing/CI Homework
Questions on Dictionary Video