search

dwardu89 / aws-ssm-parameter-store

A GitHub Action to store parameters into AWS Systems Manager Parameter Store.
Apache License 2.0
10 stars 10 forks source link

Support AWS credentials as inputs #15

Closed kjamaal closed 2 years ago

kjamaal commented 3 years ago

I wasn't able to regression test but I'm fairly sure I preserved the original logic branch. Tried to maintain the general coding standards/practices used in the original.

dwardu89 commented 3 years ago

@kjamaal this fails because you probably need to set up the access keys and sample ssm path in your branch. Otherwise if you dont want to do that, then you can raise another pull request to merge into a different branch in my repository, then i will do the testing myself.

dwardu89 commented 3 years ago

@kjamaal i was giving this PR a thought, and i dont think you need it. If you want to add a value to another aws account, you can create a set of steps that use the different access key and set it up using the aws-actions/configure-aws-credentials step.

      - name: Configure AWS Credentials
        uses: aws-actions/configure-aws-credentials@v1
        with:
          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
          aws-region: eu-west-1