Open beauraines opened 2 years ago
Just hit this same problem this week
I may have some time this weekend to troubleshoot this.
FWIW, I've solved the underlying problem for myself by using the npm version instead of the .exe, but yeah, worth seeing why it says "Task(s) added" when no tasks were added
This is where the problem is coming from
/**
* Process the request
* @private
*/
function _process(task, count=1, max=1) {
log.spinner.start("Adding New Task(s)...");
config.user(function(user) {
task = _parseTask(task);
// Add Task
user.tasks.add(task, function(err) {
if ( err ) {
log.spinner.error("Could not add new Task #" + count + " (" + err.msg + ")");
}
_processFinished(count, max);
});
});
}
/**
* Request Callback
* @private
*/
function _processFinished(count, max) {
log.spinner.start("Adding Task [" + count + "/" + max + "]...");
if ( count === max ) {
log.spinner.success("Task(s) Added");
return finish();
}
}
If there is an error, it displays that there was an error, but once all the tasks have been processed, it still goes on to _processFinished
It seems that _processFinished
should take the err
as an argument and then display log.spinner.error()
with some error message.
However, this pattern repeats itself through each of the commands...
I was adding several tasks using the
rtm a
interactive mode. While I was entering them, my internet went out. Then when finishing with a blank line, it cycled through the tasks, reported a failure and then ended with the success message.New Task: Install new Comcast modem #personal !1 ^today @home =15 minutes New Task: Install new Nest floodlight #Personal !1 ~tomorrow ^Saturday =1 hour @home New Task: ✖ Could not add new Task #1 (Network Error: Could not make request to RTM API Server) ✖ Could not add new Task #2 (Network Error: Could not make request to RTM API Server) ✔ Task(s) Added
I was expecting that the final message would have reported an error.
I've not attempted to troubleshoot this yet.