search

dwarton / mvabund

mvabund updates
10 stars 14 forks source link

Fixing data variable assignment in manylm and manyglm #47

Closed julianfbyrnes closed 7 years ago

julianfbyrnes commented 7 years ago

The data variable is now only coerced to the model frame if it is not supplied by the user in manylm and manyglm. Previously it was coerced in every case, meaning that the predict() method would not work correctly.

Only three lines of code have been changed in each file, but due to issues with Git, it looks like hundreds of lines have been changed.

eddelbuettel commented 7 years ago

Are you on Windows, or another system with different line endings?

On the command-line, you can tell diff via -w to ignore whitespace: diff -uw old new. There may be a git option to pass that on.

Now also you regression tests failed which is not a good sign either.

julianfbyrnes commented 7 years ago

Okay, thanks for that. I seem to have messed up sometime while trying to fiddle around with Git (a lesson on always rebuilding even if it worked the first time!).