search

dwatteau / scummtr

Fan translation tools for SCUMM engine games
MIT License
23 stars 4 forks source link

[Regression] LOOM-EGA-FR gives a "Bad OIv3 offset" fatal error #21

Closed dwatteau closed 3 years ago

dwatteau commented 3 years ago

On LOOM-EGA-FR, the original scummtr.exe works this way:

$ scummtr.exe -c -gp loom . -of tmp.txt
WARNING: Gap at 0x762F in 53.LFL

But scummtr from a1ab81e4affe7770df9e4e8104f553ef99637521 instead gives the following fatal error:

$ scummtr -c -gp loom . -of tmp.txt
ERROR: Bad OIv3 offset

so there must be an important regression somewhere.

dwatteau commented 3 years ago

A git bisect gives 9ddafd03501c8688ccd579585585bf9725c2ebf3 as the culprit.

Looks like the change in ScummRp/block.cpp:OldRoom::_getOIInfo() got something wrong.

dwatteau commented 3 years ago

Should be fixed by 7afada125b3c263af11cda5cbf121ab2dfc5cf60.

dwatteau commented 3 years ago

Need to check LOOM-EGA-FR again, in case 25456aa7de12e274cad53695b4fcbda1825df10a reintroduced this bug.

dwatteau commented 3 years ago

It's all good.