[Portability] FontXY and ScummFont fail on big-endian systems

dwatteau / scummtr

Fan translation tools for SCUMM engine games

MIT License

23 stars 4 forks source link

[Portability] FontXY and ScummFont fail on big-endian systems #3

Closed dwatteau closed 3 years ago

dwatteau commented 3 years ago

This was quickly tested on a ppc32 system, but it seems that FontXY and ScummFont have no endianness check, and so they just fail or give improper results on these systems.

dwatteau commented 3 years ago

PR #24 is an attempt at fixing this.

Lots of tests will be required.

dwatteau commented 3 years ago

When using this branch:

BMP output files are the same on ppc and x86 ✅
reimported CHAR/LFL files are on the same on ppc and x86 ✅
compare BMP/CHAR/LFL files on ppc, x86 with the patch and x86 without the patch ✅

i.e. the generated checksums are the same on little-endian and big-endian systems, and the output is the same on little-endian systems with or without the patch.

Tested with ATLANTIS-FLOPPY-FR, DIG-FR, LOOM-EGA-EN, MONKEY2, PASSPORT, TENTACLE-FR, ZAK-TOWNS.

dwatteau commented 3 years ago

Should be fixed by #24 which has just been merged :)