[Regression] MANIAC-V2/ZAK-V2 are broken in ScummTR 0.5.0

dwatteau commented 2 years ago

Summary

Trying to extract the text of MANIAC-V2-FR (from my DOTT CD) with the officia: ScummTR 0.5.0 release unfortunately shows a late regression :(

$ scummtr -g maniacv2 -c -l fr -of tmp.txt
ERROR: Bad OIv2 offset

A bit of git bisect shows that this regression appeared with the extra "safety" I added in commit 8322e6da739a82dd4511474f152679ee303a0bd7. Looks like I was wrong...

Impacted games

Maniac Mansion

ScummTR versions

v0.5.0

I own a legitimate game

[X] I promise that my game does NOT come from an illegal source, such as "abandonware" websites

dwatteau commented 2 years ago

Commit 8322e6da739a82dd4511474f152679ee303a0bd7 was reverted by commit ef6031791135b1cefd109a6be54a51010826c9d2.

This is scheduled for the 0.5.1 release.

dwatteau commented 2 years ago

Also fixes the same problem in Zak V2 (from GOG).

dwatteau commented 2 years ago

Closing, since 0.5.1 was released with this fix on 2022-02-27.

dwatteau / scummtr