search

dwatteau / scummtr

Fan translation tools for LucasArts SCUMM games
MIT License
25 stars 4 forks source link

[Parsing] MONKEY1-AMIGA: LFLF 61 differently indexed from one file to another #56

Open dwatteau opened 2 years ago

dwatteau commented 2 years ago

Summary

With the Amiga version of Monkey1, from LRG's Monkey Island Anthology.

Trying to reimport the original text content, but with an added -A ao flag so that extra padding is inserted (and so that some bytes differ) will result in the following fatal error:

$ scummtr -g monkey -A ao -of test.txt
$ scummtr -g monkey -A ao -if test.txt
ERROR: LFLF 61 differently indexed from one file to another

This looks similar to issue #54, but the error message is different. As far as I can say, the Amiga version is the closest version to the VGA-DOS version.

This error also happens with the original 2003 scummtr.exe, so this isn't a regression.

Impacted games

The Secret of Monkey Island

ScummTR versions

v0.5.1, v0.4.0

I own a legitimate game

dwatteau commented 2 years ago

Since this appears related to the #54 issue, the fix will probably be the same

https://github.com/dwatteau/scummtr/issues/54#issuecomment-1117823889

i.e., work around the (official) invalid resources of Monkey1 VGA.

gabberhead commented 2 weeks ago

i have the same problem with the german amiga version of the game. i did a retranslation like i did for the vga verman version. i can extract the text, but the import gives me the same error.

dwatteau commented 2 weeks ago

Ah yes that problem. Some releases of Monkey1 have broken resources, that would require a different approach to SCUMMv4 parsing.

Something like this:

https://bitbucket.org/jestar_jokin/scummpacker/commits/96f34dc6a2b947dea259382387c574329c819efe

or the ScummVM equivalent

It's not very hard to do, but it requires a good understanding of the resources, which I don't really have.

I had interest and time in fixing this some years ago when I opened this issue, but nowadays I don't know if it's going to happen from me. The NUTCracker project is supporting more and more SCUMM games and is more actively maintained, with a newer and cleaner architecture, so the efforts and time are maybe better spent in this sister project instead.

Anyway: maybe it's going to be fixed in scummtr some day, but I doubt I will doing it myself or soon, sorry…

gabberhead commented 2 weeks ago

I know nutcracker also. But it works only with scumm v5+ ganes. Till now :) Monkey Island 1 is v4. And I dont know other Tools, for editing the Text.

dwatteau commented 2 weeks ago

I know nutcracker also. But it works only with scumm v5+ ganes. Till now :) Monkey Island 1 is v4. And I dont know other Tools, for editing the Text.

Sure, but nutcracker had WIP code for v4 I think – at least Loom or something like that. You can reach out 'rzil' on the ScummVM Discord for this. Monkey1 is maybe on his roadmap; I'd suggest mentioning the 'scummpacker' link above to him, so that he remains aware of some v4 parsing particularities.

(Of course he's also doing this work on his free time and may choose not to work on this now etc.)

gabberhead commented 4 days ago

german indy atlantis amiga version, has the same problem like monkey 1.