dwavesystems / dwave-gate

dwave-gate is a software package for constructing, modifying and running quantum circuits on the provided state-vector simulator.
Apache License 2.0
12 stars 7 forks source link

Support for Py3.7? #36

Open JoelPasvolsky opened 1 year ago

JoelPasvolsky commented 1 year ago

The numpy==1.22.4 requirement seems incompatible with Python 3.7: ERROR: No matching distribution found for numpy==1.22.4

Should this repo not support 3.7 (we say Python versions >=3.7 are supported for Ocean) or update to something like numpy==1.21.6; python_version < '3.8' (did not test if compatible with other packages used in this repo)?

arcondello commented 1 year ago

The requirements.txt are not necessarily synonymous with support, though it would be nice if all of the Python versions we support could install via the requirements.

JoelPasvolsky commented 1 year ago

Also, while make install succeeds in Python 3.9, it fails in 3.7:

    from dwave.gate.registers.registers import (
  File "/home/jpasvolsky/Work/MyVirtualEnvironments/dwave_gate_37/dwave-gate/dwave/gate/registers/__init__.py", line 21, in <module>
    from dwave.gate.registers.registers import *
  File "/home/jpasvolsky/Work/MyVirtualEnvironments/dwave_gate_37/dwave-gate/dwave/gate/registers/registers.py", line 37, in <module>
    from dwave.gate.registers.cyregister import cyRegister
ModuleNotFoundError: No module named 'dwave.gate.registers.cyregister'
makefile:31: recipe for target 'install' failed
make: *** [install] Error 1
thisac commented 1 year ago

I've had that happen before, and IIRC it got resolved when reinstalling cgen and cython. Not sure why exactly, but trying installing it from scratch in a 3.7 environment it works fine for me as long as I have those two + python3.7-dev installed (Ubuntu 20.04).