dwavesystems / dwave-neal

An implementation of a simulated annealing sampler for general Ising model graphs in C++ with a dimod Python wrapper.
https://docs.ocean.dwavesys.com/projects/neal/en/latest
Apache License 2.0
51 stars 45 forks source link

Fix appveyor wheel construction for python3.4 #40

Closed arcondello closed 6 years ago

arcondello commented 6 years ago

Closes #39

codecov-io commented 6 years ago

Codecov Report

Merging #40 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #40   +/-   ##
====================================
  Coverage      99%   99%           
====================================
  Files           2     2           
  Lines         100   100           
====================================
  Hits           99    99           
  Misses          1     1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 985a2fe...8d0edc7. Read the comment docs.

randomir commented 6 years ago

Are you sure this fixes the issue #39?

Tests always worked -- the problem was with the deploy script (which builds the wheel).

arcondello commented 6 years ago

you're right, I was distracted. I will continue working on it

arcondello commented 6 years ago

I was right the first time, it was the wheel building step which happens every time