search

dwavesystems / dwave-neal

An implementation of a simulated annealing sampler for general Ising model graphs in C++ with a dimod Python wrapper.
https://docs.ocean.dwavesys.com/projects/neal/en/latest
Apache License 2.0
50 stars 44 forks source link

Drop python 3.5 and remove support for numpy 1.21.0, 1.21.1 #95

Closed hhtong closed 3 years ago

hhtong commented 3 years ago
codecov-commenter commented 3 years ago

Codecov Report

Merging #95 (e8d62cb) into master (6717614) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files           3        3           
  Lines          75       75           
=======================================
  Hits           74       74           
  Misses          1        1
Impacted Files Coverage Δ
neal/sampler.py 98.48% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6717614...e8d62cb. Read the comment docs.

hhtong commented 3 years ago

LGTM, though IMO we could test each minor version in the dimod/numpy range while we're at it.

Agreed, I've added testing for each of the minor version combinations as suggested. Though it is now 40+ jobs..

The exclude section of the CircleCI config file is pretty ugly right now, not sure if there is a nicer way to write it. This is probably something that can be added to the ocean orb later on.

arcondello commented 3 years ago

The latest dimod only supports numpy>=1.17.3 and as of July 26, numpy only supports 1.18+ so IMO we can cut it down a bit.