Open wbernoudy opened 1 month ago
We do not currently enforce clang-formatted code. We could consider doing so as well.
Agreed! For now at least, it would be nice to just have a note in the readme.
I don't think this is easy.
The ecosystem as a whole doesn't have a lot of consensus.
apt install clang format
pulls in 14.0.0For internal repos, I am reasonably comfortable enforcing a version. But for public repos like this, where we want to encourage contribution from users, I don't think it's reasonable to require folks to install a specific version of clang simply to make a PR against this repo.
We could format as part of CI, but that comes with its own issues.
Since we expect the C++ code to be formatted with
clang-format
, but there are inconsistencies between different versions, we should specify the version one is expected to use when doing development.