search

dwavesystems / dwave-optimization

Enables the formulation of nonlinear models for industrial optimization problems.
https://docs.ocean.dwavesys.com/en/stable/docs_optimization/index.html#index-optimization
Apache License 2.0
7 stars 18 forks source link

Add SquareRoot symbol #165

Closed mdcoury closed 1 week ago

mdcoury commented 1 week ago

Initial add for square_root node, no unit-testing yet... want some feedback on the approach because I don't recall it being so clunky to add a new node when I did this before.

mdcoury commented 1 week ago

@[arcondello](https://github.com/arcondello) arcondello changed the title Add new nodes Add SquareRoot symbol [18 hours ago](https://github.com/dwavesystems/dwave-optimization/pull/165#event-15290629930)

There are two nodes being added. I was going to put them both in this PR: do you want them put into separate PRs?

arcondello commented 1 week ago

do you want them put into separate PRs?

They don't need to be, you can change the name again. But "Add new nodes" is not very meaningful, and I often look at the PR titles when writing release notes etc, so if you add another node you can just call it out in the name.

arcondello commented 6 days ago

Closed in favour of https://github.com/dwavesystems/dwave-optimization/pull/169