dwavesystems / dwave-system

An API for easily incorporating the D-Wave system as a sampler, either directly or through Leap's cloud-based hybrid samplers
https://docs.ocean.dwavesys.com/
Apache License 2.0
87 stars 62 forks source link

Update clique.py: Add local Composite #417

Closed pierrelouisp closed 3 years ago

pierrelouisp commented 3 years ago
pierrelouisp commented 3 years ago
arcondello commented 3 years ago

Approach looks good. Can we add some tests? It should be possible to adapt the mock sampler and tests in https://github.com/dwavesystems/dwave-system/blob/master/tests/test_dwavecliquesampler.py to create a breaking case.

codecov-commenter commented 3 years ago

Codecov Report

Merging #417 (efb5461) into master (fb38541) will decrease coverage by 1.63%. The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   92.11%   90.48%   -1.64%     
==========================================
  Files          22       22              
  Lines        1332     1366      +34     
==========================================
+ Hits         1227     1236       +9     
- Misses        105      130      +25     
Impacted Files Coverage Δ
dwave/system/samplers/clique.py 78.61% <58.82%> (-5.39%) :arrow_down:
dwave/system/samplers/dwave_sampler.py 84.37% <0.00%> (-3.13%) :arrow_down:
dwave/system/samplers/leap_hybrid_sampler.py 74.45% <0.00%> (-2.92%) :arrow_down:
dwave/system/composites/embedding.py 95.85% <0.00%> (-1.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb38541...efb5461. Read the comment docs.