Open pau557 opened 3 months ago
Attention: Patch coverage is 83.33333%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 86.57%. Comparing base (
b233941
) to head (5867eba
). Report is 31 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
dwave/system/composites/linear_ancilla.py | 83.09% | 12 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Any more comments or ready to merge?
I had missed many comments, apologies @JoelPasvolsky. I think everything is addressed now
@pau557, I think we can merge this when docs comments are addressed.
How do I tell CircleCI not to run this example with a mock sampler?
/home/circleci/project/dwave/system/testing.py:325: UserWarning: 'flux_biases' parameter is valid for DWaveSampler(), but not mocked in MockDWaveSampler().
warnings.warn(f'{kw!r} parameter is valid for DWaveSampler(), '
/home/circleci/project/dwave/system/testing.py:325: UserWarning: 'fast_anneal' parameter is valid for DWaveSampler(), but not mocked in MockDWaveSampler().
warnings.warn(f'{kw!r} parameter is valid for DWaveSampler(), '
WARNING: **********************************************************************
File "../dwave/system/composites/linear_ancilla.py", line ?, in default
Failed example:
sampleset.first.energy
Expected:
-3
Got:
1.0
How do I tell CircleCI not to run this example with a mock sampler?
/home/circleci/project/dwave/system/testing.py:325: UserWarning: 'flux_biases' parameter is valid for DWaveSampler(), but not mocked in MockDWaveSampler(). warnings.warn(f'{kw!r} parameter is valid for DWaveSampler(), ' /home/circleci/project/dwave/system/testing.py:325: UserWarning: 'fast_anneal' parameter is valid for DWaveSampler(), but not mocked in MockDWaveSampler(). warnings.warn(f'{kw!r} parameter is valid for DWaveSampler(), ' WARNING: ********************************************************************** File "../dwave/system/composites/linear_ancilla.py", line ?, in default Failed example: sampleset.first.energy Expected: -3 Got: 1.0
You can mock the flux_biases parameter with h if you want this to behave correctly. You can also suppress the warnings. e.g. https://github.com/AndyZzzZzzZzz/shimming-tutorial/blob/development/tutorial_code/helpers/sampler_wrapper.py I think its worth testing
In scenarios where the h biases are not available or sufficient in range, one can use auxiliary qubits polarized with a large flux bias and coupled to the data qubit. This method:
This PR adds a LinearAncillaComposite that implements this technique.
For the reviewers, please take into account future extensions of this method:
Please educate me on how to use the correct Sphynx syntax