search

dwavesystems / minorminer

minorminer is a heuristic tool for minor embedding: given a minor and target graph, it tries to find a mapping that embeds the minor into the target.
https://docs.ocean.dwavesys.com/en/stable/docs_minorminer/source/sdk_index.html
Apache License 2.0
47 stars 39 forks source link

busclique finds cliques that aren't confirmed by the python polytime embedder #153

Open boothby opened 4 years ago

boothby commented 4 years ago

edit: There's an issue in how the polytime embedder handles bad internal couplers

See #151 and #152. Seems to be impacting chimera graphs with a small number of bad edges

boothby commented 4 years ago

Oops. I misread those logs. The issue is actually in the python polytime embedder, which isn't (yet) minorminer's responsibility. Leaving this open because I'll eventually want to fix that.

arcondello commented 4 years ago

@boothby , potentially closed by https://github.com/dwavesystems/dwave-system/issues/325?

boothby commented 4 years ago

Yes-ish? There's still some value in that python code:

  1. it can handle arbitrary shore sizes; the c++ is limited to 8
  2. it can be used to sample from the space of maximum-size embeddings (with caveats), where the c++ is deterministic (with caveats)

So for now, I don't plan to remove it altogether.